Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tests for redis-stack #2052

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Mar 16, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #2052 (a73fb9e) into master (95b3268) will decrease coverage by 0.47%.
The diff coverage is 38.96%.

@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
- Coverage   91.68%   91.20%   -0.48%     
==========================================
  Files         100      100              
  Lines       21228    21248      +20     
==========================================
- Hits        19462    19379      -83     
- Misses       1766     1869     +103     
Impacted Files Coverage Δ
tests/test_commands.py 94.62% <31.57%> (-1.67%) ⬇️
tests/test_scripting.py 93.58% <33.33%> (-6.42%) ⬇️
tests/test_bloom.py 99.55% <100.00%> (+0.01%) ⬆️
redis/commands/core.py 82.92% <0.00%> (-2.27%) ⬇️
tests/conftest.py 86.40% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b3268...a73fb9e. Read the comment docs.

@chayim chayim self-requested a review March 16, 2022 12:08
@dvora-h dvora-h merged commit 878e2f2 into redis:master Mar 16, 2022
@dvora-h dvora-h deleted the mark-tests-redistack branch May 9, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants